CHAD-17042: zb-motion: Lazy loading of can handle and scripting testing ground #2551
Conversation
|
Invitation URL: |
Test Results 71 files 475 suites 0s ⏱️ Results for commit d723c87. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d723c87 |
aleclorimer
force-pushed
the
task/zigbee-motion-sensor-lazy-load-subdrivers
branch
from
0ae4dbb to
993cfb0
Compare
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
LGTM, just a few formatting nits that are nice to have. Did the test suite get run against 0.58 lua libs? CI is now running 0.59 lua libs, and we need to check that 58 doesnt have failing tests related to this.
drivers/SmartThings/zigbee-motion-sensor/src/aqara/sub_drivers.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/zigbee-motion-sensor/src/battery-voltage/fingerprints.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/zigbee-motion-sensor/src/centralite/can_handle.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/zigbee-motion-sensor/src/samjin/can_handle.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/zigbee-motion-sensor/src/smartthings/can_handle.lua
Outdated
Show resolved
Hide resolved
greens
left a comment
greens
left a comment
There was a problem hiding this comment.
While you're touching all of these files, would it be possible to replace the existing copyright/license statement with the shorter one?
aleclorimer
changed the title
aleclorimer
force-pushed
the
task/zigbee-motion-sensor-lazy-load-subdrivers
branch
from
4437ba7 to
cfc0b30
Compare
aleclorimer
force-pushed
the
task/zigbee-motion-sensor-lazy-load-subdrivers
branch
from
cfc0b30 to
d723c87
Compare
|
Gona merge this today unless there are any objections. The latest changes were the newlines, copyright updates and squashing commits. |
|
Did the test suite get run against 0.58 lua libs? CI is now running 0.59 lua libs, and we need to check that 58 doesnt have failing tests related to this. |
Lazy loading of the
zigbee-motion-sensorsub drivers with thecan_handlelazy loading.This driver was modified heavily by the use of a script I've been developing to automate this process for the rest of the zigbee, zwave and matter drivers. This is the first PR & driver refactored with the assistance of the script (though still massaged to pass all driver tests by me).