-
Notifications
You must be signed in to change notification settings - Fork 89
Description
The nodejs tests for a DIAL server have multiple issues where incorrect codes are expected in response to a POST request to the Application Resource URL:
-
https://github.com/Netflix/dial-reference/blob/master/server/tests/js_tests/tests/launchApplicationInRunningStateWithPayload.js#L86
These tests expect a201 Createdwhen 6.2.2 of the DIAL 2.2 spec indicates200 OKshould be returned if application state isRunning. A201 Createdis only appropriate if the application is not currently running or it is hidden.
For the launchApplicationInRunningStateWithPayload test, if the current application does not support payloads or fails to process the payload, a501 Not Implementedis also acceptable (new for DIAL 2.2) -
https://github.com/Netflix/dial-reference/blob/master/server/tests/js_tests/tests/hideInvalidApplicationInstance.js#L39
Similar to the above issues, this test expects a201 Createdresponse regardless the current state of the application, when 6.2.2 of the DIAL 2.2 spec indicates200 OKshould be returned if application state isRunningorStartingand201 Createdshould be returned if the application stateStopped. However, this test assumes the application is not currently running and is missing the startAppIfNotRunning() function found in other tests. This assumption can result in intermittent failures of this test.