-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
some notes of things I (@vrde) want to fix in the feature freeze phase
Add a "whenever possible" in front of all these items:
-
uintshould beuint256(add linter) - functions should be marked virtual to make them overridable by new proxy implementations #26
- contracts must have an interface and implement it (e.g.
Votingdoesn't implementIVoting) #27 -
Basecontracts should not expose public methods #28 - unify ACL control sometimes we use
AccessControl, sometimes we use a custom modifier #29 - Update integration tests to use token amounts in Ether, not Wei #45
- use simpler interfaces (search for
IERC20Upgradeable) - review all
FIXMEs,TODOs -
lib/utils.tsandlib/config.tsoverlap, merge them
Metadata
Metadata
Assignees
Labels
No labels