Skip to content

num_epochs should not default to 10 if max_steps is specified in step scheduler #1095

@torsli

Description

@torsli

Describe the bug

If the step scheduler section of config file specifies max_steps but not num_epochs, the value of num_epochs defaults to 10 and this can effectively overwrite the value of max_steps, depending on the size of the dataset.

Steps/Code to reproduce bug

Run a recipe with num_epochs unset and max_steps set to a value more than 10x the number of steps needed per epoch.

Expected behavior

num_epochs remains unset if max_steps is specified instead.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions