-
Notifications
You must be signed in to change notification settings - Fork 394
Add capability host creation instructions and update agent version #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -272,6 +272,22 @@ Before you create the agent, give your project's managed identity access to pull | |||||||||
|
|
||||||||||
| 1. Grant pull permissions by assigning the Container Registry Repository Reader role to your project's managed identity on the container registry. For detailed steps, see [Azure Container Registry roles and permissions](/azure/container-registry/container-registry-roles). | ||||||||||
|
|
||||||||||
| ### Create account-level Capability Host | ||||||||||
|
|
||||||||||
| Updating capability hosts is not supported. If you have existing capability host for your Foundry account, you must delete the existing one and recreate it with the property "enablePublicHostingEnvironment" set to true. | ||||||||||
|
||||||||||
| Updating capability hosts is not supported. If you have existing capability host for your Foundry account, you must delete the existing one and recreate it with the property "enablePublicHostingEnvironment" set to true. | |
| Updating capability hosts is not supported. If you have existing capability host for your Foundry account, you must delete the existing one and recreate it with the property "enablePublicHostingEnvironment" set to true. |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing article "an" before "existing capability host". The sentence should read "If you have an existing capability host for your Foundry account..."
| Updating capability hosts is not supported. If you have existing capability host for your Foundry account, you must delete the existing one and recreate it with the property "enablePublicHostingEnvironment" set to true. | |
| Updating capability hosts is not supported. If you have an existing capability host for your Foundry account, you must delete the existing one and recreate it with the property "enablePublicHostingEnvironment" set to true. |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cURL command lacks introductory text explaining what the command does or when to use it. Consider adding a brief introduction before the code block, such as "To create the account-level capability host with public hosting enabled, use the following Azure REST API call:" This follows the pattern used elsewhere in the document (see lines 237-240, 293).
| To create the account-level capability host with public hosting enabled, use the following Azure REST API call: |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cURL example contains hardcoded subscription ID, resource group name, and account name that appear to be specific to a test environment ("arthfa-ncus"). These should be replaced with placeholders or generic example values to prevent confusion and potential security issues.
Consider using placeholders like:
{subscription-id}oryour-subscription-id{resource-group-name}oryour-resource-group{account-name}oryour-foundry-account
| --url 'https://management.azure.com/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourceGroups/arthfa-ncus/providers/Microsoft.CognitiveServices/accounts/arthfa-ncus/capabilityHosts/accountcaphost?api-version=2025-10-01-preview' \ | |
| --url 'https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}/providers/Microsoft.CognitiveServices/accounts/{account-name}/capabilityHosts/accountcaphost?api-version=2025-10-01-preview' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading uses sentence case ("Capability Host") instead of the expected lowercase style for multi-word terms. According to Microsoft Writing Style Guide, headings should be in sentence case. This should be "Create account-level capability host" (with "capability host" in lowercase).