-
Notifications
You must be signed in to change notification settings - Fork 393
subnet IP address update to match Class A range #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Before this change, the text reads "subnets must have IP ranges under `10.0.0.0/16`, `172.16.0.0/12` or `192.168.0.0/16`, which are class A, B or C private address ranges reserved for private networking" Are you sure if this is correct? It smells like an error, because the reserved private address range of class A is "10.0.0.0/8". /16 is not a class A network, so there is an inconsistency anyway. Would you please check this? This is an important architecture detail.
|
@khaliddermoumi : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit fbce9d4: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
10.0.0.0/8 does work - so believe it is a typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects a technical error in the documentation regarding private IP address ranges for virtual network subnets. The change updates the Class A private address range from the incorrect 10.0.0.0/16 to the correct 10.0.0.0/8 as defined in RFC 1918.
Key changes:
- Corrected the Class A private IP address range CIDR notation from /16 to /8
Before this change, the text reads "subnets must have IP ranges under
10.0.0.0/16,172.16.0.0/12or192.168.0.0/16, which are class A, B or C private address ranges reserved for private networking" Are you sure if this is correct? It smells like an error, because the reserved private address range of class A is "10.0.0.0/8". /16 is not a class A network, so there is an inconsistency anyway. Would you please check this? This is an important architecture detail.