Integrated placeholders broken after update

[Nesseley]

Description of Bug

All placeholders used to work before I updated the plugin, now they break sometimes and works for one player, but another might not. Then they fix themselves randomly. Once they fix themselves, they stay fixed.

Example:
{mobkilling:complete} &7ᴅʀᴇᴘ %math_0:1_20-{mobkilling:progress}% ɢᴏᴀᴛ in config shows me this when hovering the quest:

Then it will fix itself randomly and show as it should. Reloading the plugin or restarting the server doesn't fix it.

Steps to Reproduce

Create a new quest and hover the quest.

Environment

• Minecraft version: 1.21.8
• Server software: Paper version 1.21.8-60-main@29c8822
• Quests version: 3.15.2-b8ef62d

Agreements

• I am running the latest version of Quests
• I am certain this issue is unique and a similar issue is not currently open
• I am using a version of Minecraft which is supported by Quests

Other

No response

[Krakenied]

Probably regression after #760 fix.

Not really an issue - it's just that, placeholder renderer isn't meant to generate blank quest progress. It happens when you add a new task to a quest while having it already started.

Getting progress or restarting the quest (possibly with moddata reset?) will get your progress display back.

[Nesseley]

aha yeah, it does seem to behave like that.

[Kepler616]

It's happening to me right now, I have tried everything and it's just not working

Environment
Minecraft version: 1.21.10
Server software: Paper version 1.21.10
Quests version: 3.16.1-430c34a

[Krakenied]

It's happening to me right now, I have tried everything and it's just not working

Environment
Minecraft version: 1.21.10
Server software: Paper version 1.21.10
Quests version: 3.16.1-430c34a

qc isn't a Quests placeholder expansion identifier. Ensure that your placeholders in menus are enabled (config.yml) and that you have necessary external qc (not related to Quests) PlaceholderAPI expansion installed.

[Nesseley]

aha yeah, it does seem to behave like that.

Hm maybe not, a player that just got to this quest (unlocked by a previous quest) reported to seeing the placeholders wrong. Even when the quest was added before last restart, and the player didn't have the quest already started or even visible to them.

Weird that this used to work 100% of the time, and its not working like it used to

[Krakenied]

aha yeah, it does seem to behave like that.

Hm maybe not, a player that just got to this quest (unlocked by a previous quest) reported to seeing the placeholders wrong. Even when the quest was added before last restart, and the player didn't have the quest already started or even visible to them.

Weird that this used to work 100% of the time, and its not working like it used to

In %% or {} placeholders?

It used to work because the plugin no longer generates internally "empty" progress for placeholder resolutions (as it caused some concurrency issues with quest completer).

However I don't really know how to reproduce it - need some repro case to fix it.

I will do some investigation on this issue on my own though, maybe I will be able to repro it.

How did your player start that quest? There is a possibility that the GUI is refreshed too early after starting it. Do you use auto start feature? Do you use it globally or per quest? Has the issue disappeared after some time?