Call World:__flush in World:getEntities()

[pkhead]

Currently, when World:getEntities() is called after creating some entities but before a World:emit, the returned list in World:getEntities() does not actually reflect the current world state. I feel like this might be a bug. Inserting a flush call in World:getEntities() fixes this.

too lazy to fork this to make a PR, sorry. I'm busy in a game jam :p. also i feel like having to fork the repo just to make one code change is a little overkill.

[pablomayobre]

There is some nuance here, "does not currently reflect the current world state" is not accurate.

Basically when you call emit() you freeze the World so that your System can execute and make all the needed modifications. Before the Systems start executing we call flush() internally and that means that all Systems receive the most up to date version of the World.

BUT, once you are inside of an emit() we can't continue updating the World, if you were to modify the Entities on the Pool that the System is iterating through you could run into issues of double counting or ignoring some Entities. That's why no operation flushes by default.

You can manually flush if you are not happy with this behavior.

I wrote more here

[pablomayobre]

Happy to see a PR, but make the flush optional