Skip to content

Make comments non-blocking by defaultΒ #117892

@goerz

Description

@goerz

I appreciate the community review of the General registry, in that anyone can leave a blocking comment on a new registration. However, the more "community review" actually happens, and thus, the more comments there are for registration PRs, the more it is a problem that comments are blocking by default.

I would propose that we change from comments being blocking unless they contain [noblock] to comments being non-blocking unless they contain [block]. I have no problem personally navigating [noblock], but I have to spend a very significant percentage of my registry review time just typing messages to people reminding them to add [noblock]. Latest example:

#117882

It's very easy to forget about [noblock] once a discussion gets going. My experience is also that 90% of comments are intended to be non-blocking. Those that are intended to block are usually just the first comment, and usually by a small group of people (myself included) that check new submissions for issues such as misleading names or insufficient documentation. I think that group of people will easily adapt to [block].

P.S.: I'm not sure if this issue belongs here, or, e.g., in https://github.com/JuliaRegistries/RegistryCI.jl. Please feel free to transfer if appropriate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions