NPE with null values

[rvansa]

yaup/src/main/java/io/hyperfoil/tools/yaup/json/Json.java

Line 1222 in 92b1cc3

if(!this.get(key).equals(other.get(key))){

This line fails with NPE if the value is null.

[shivarm]

@rvansa

if (thisValue == null && otherValue == null) {
            // Both values are null, consider them equal
            continue;
        }
        
        if (thisValue == null || otherValue == null || !thisValue.equals(otherValue)) {
            return false;
        }
    }
}

In this modified version, before invoking the equals() method, it first checks if either thisValue or otherValue is null. If both values are null, they are considered equal, and the loop proceeds to the next key. If either value is null or the values are not equal, the method returns false.

By including the null check, you can prevent the NullPointerException from occurring when comparing values that can be null.

[johnaohara]

@shivam-sharma7 do you want to open a PR to fix this issue?

[shivarm]

@johnaohara I'm not sure about this. What you thing about the code?
#28 (comment)