Sporadic test failure in LocalAppEnginePublishOperationTest

[briandealwis]

Test failure on Java 7 with Mars. Failing code attempts to obtain the WTP IModule for the shared project:

    sharedModule = ServerUtil.getModule(sharedProject);
    assertNotNull(sharedModule);

Nothing interesting on the transcript:

Running com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest
[Watchdog] > testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.134 sec <<< FAILURE! - in com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest
testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)  Time elapsed: 2.132 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:712)
	at org.junit.Assert.assertNotNull(Assert.java:722)
	at com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest.setUp(LocalAppEnginePublishOperationTest.java:72)

[chanseokoh]

I can confirm this is not new. I have seen this occasionally (quite infrequently fortunately) for a very long time.

[chanseokoh]

Failing in the same test class but at a slightly different location:

testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)  Time elapsed: 3.875 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest.testPublishingSubmodules(LocalAppEnginePublishOperationTest.java:114)

The class file classes/sox/server/GreetingServiceImpl.class doesn't seem to exist in the publish directory.

[chanseokoh]

Got another interesting error:

testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)  Time elapsed: 6.875 sec  <<< FAILURE!
java.lang.AssertionError: Imported projects have errors
/sox-server:-1: The project cannot be built until build path errors are resolved
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.failIfBuildErrors(ProjectUtils.java:143)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.failIfBuildErrors(ProjectUtils.java:137)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.importProjects(ProjectUtils.java:123)
	at com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest.setUp(LocalAppEnginePublishOperationTest.java:57)

[briandealwis]

Hit again (full log) on Neon. I wonder if there's a pending operation happening here.

[Watchdog] > testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)
Window manager warning: Buggy client sent a _NET_ACTIVE_WINDOW message with a timestamp of 0 for 0x80025b (User Opera)
Window manager warning: meta_window_activate called by a pager with a 0 timestamp; the pager needs to be fixed.
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.711 sec <<< FAILURE! - in com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest
testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)  Time elapsed: 3.682 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest.testPublishingSubmodules(LocalAppEnginePublishOperationTest.java:114)

[chanseokoh]

So we get errors at various stages:

• Sporadic test failure in LocalAppEnginePublishOperationTest #1798 (comment) : "The project cannot be built until build path errors are resolved", a build error that we missed to wait for to be cleared. Note this code, so waitForProjects() slipped a build error which it shouldn't.
• Sporadic test failure in LocalAppEnginePublishOperationTest #1798 (comment): projects opened without errors, but ServerUtil.getModule() fails.
• Sporadic test failure in LocalAppEnginePublishOperationTest #1798 (comment) and Sporadic test failure in LocalAppEnginePublishOperationTest #1798 (comment): although some static files (such as web.xml) are published, the class file GreetingServiceImpl.class doesn't exist in the publish directory.

We know ProjectUtils.waitForProjects() does wait for auto-build jobs until there won't be any build errors. I wonder if we need to call refreshLocal() at this point.

[briandealwis]

Maybe call ThreadDumpingWatchdog#run() to see what other jobs are pending?

[briandealwis]

Seen on the Java 7/Mars build:

Running com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest
[Watchdog] > testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)
Importing 2 projects:
    /home/travis/build/GoogleCloudPlatform/google-cloud-eclipse/plugins/com.google.cloud.tools.eclipse.appengine.localserver.test/target/work/data/sox-server/.project
    /home/travis/build/GoogleCloudPlatform/google-cloud-eclipse/plugins/com.google.cloud.tools.eclipse.appengine.localserver.test/target/work/data/sox-shared/.project
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.882 sec <<< FAILURE! - in com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest
testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)  Time elapsed: 2.879 sec  <<< FAILURE!
java.lang.AssertionError: Imported projects have errors
/sox-server:-1: The project cannot be built until build path errors are resolved
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.failIfBuildErrors(ProjectUtils.java:167)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.failIfBuildErrors(ProjectUtils.java:161)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.importProjects(ProjectUtils.java:147)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.importProjects(ProjectUtils.java:89)
	at com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest.setUp(LocalAppEnginePublishOperationTest.java:57)

[elharo]

Another one:

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.095 sec <<< FAILURE! - in com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest
testPublishingSubmodules(com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest)  Time elapsed: 3.092 sec  <<< FAILURE!
java.lang.AssertionError: Imported projects have errors
/sox-server:-1: The project cannot be built until build path errors are resolved
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.failIfBuildErrors(ProjectUtils.java:167)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.failIfBuildErrors(ProjectUtils.java:161)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.importProjects(ProjectUtils.java:147)
	at com.google.cloud.tools.eclipse.test.util.project.ProjectUtils.importProjects(ProjectUtils.java:89)
	at com.google.cloud.tools.eclipse.appengine.localserver.server.LocalAppEnginePublishOperationTest.setUp(LocalAppEnginePublishOperationTest.java:57)