Information is lost when passing a dynamic array of strings as a char** to a backend

[tegonzalo]

Recently after we enabled pedantic errors, Greg changed the static initialisation of arrays in FlavBit, for the interface with SuperIso, to dynamic arrays. Well turns out that the info in the arrays is corrupted as it's passed somehow. The pointer provided is correct, but just filled with garbage when it gets to the backend.

[gregorydavidmartinez]

Could you remind me quick file that was in?

[gregorydavidmartinez]

OK, so I guess we are talking about passing obsnames and obsnames_ptr in file FlavBit.cpp? Could I get a concrete example where this fails (I've having trouble reproducing this)?

[tegonzalo]

Uhm, I'm also not able to reproduce this on master. This popped up when I merged master onto another branch, but it might be then related to the other stuff, which I didn't think it was. Let me do more testing then, maybe this is a dud.

[patscott]

Try with both GCC and clang; dynamic allocation at runtime is against the std but works with one of then and gives undefined behavior w the other

…

On Fri, 18 Oct 2024, 8:07 am Tomas Gonzalo, ***@***.***> wrote: Uhm, I'm also not able to reproduce this on master. This popped up when I merged master onto another branch, but it might be then related to the other stuff, which I didn't think it was. Let me do more testing then, maybe this is a dud. — Reply to this email directly, view it on GitHub <#512 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJRC6NPUTLBX5DFO4PKQ4LZ4AYJDAVCNFSM6AAAAABQEEYKHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGY4DIMRTHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>