Skip to content

Commit 0874236

Browse files
committed
Fix track version if empty (Fixes #388). Updated tests
1 parent 0c3b851 commit 0874236

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

tests/test_media.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -504,25 +504,18 @@ def test_video_image(session):
504504
verify_image_resolution(session, video.image(1080, 720), 1270, 1270)
505505

506506

507-
def test_full_name_track_1(session):
508-
track = session.track(149119714)
509-
assert track.name == "Fibonacci Progressions (Keemiyo Remix)"
510-
assert track.version is None
511-
assert track.full_name == "Fibonacci Progressions (Keemiyo Remix)"
512-
513-
514-
def test_full_name_track_2(session):
507+
def test_full_name_track_version_available(session):
515508
track = session.track(78495659)
516509
assert track.name == "Bullitt"
517510
assert track.version == "Bonus Track"
518511
assert track.full_name == "Bullitt (Bonus Track)"
519512

520513

521-
def test_full_name_track_3(session):
522-
track = session.track(98849340)
523-
assert track.name == "Magical place (feat. IOVA)"
524-
assert track.version == "Dj Dark & MD Dj Remix"
525-
assert track.full_name == "Magical place (feat. IOVA) (Dj Dark & MD Dj Remix)"
514+
def test_full_name_track_version_none(session):
515+
track = session.track(113210329)
516+
assert track.name == "Enormous"
517+
assert track.version is None
518+
assert track.full_name == "Enormous"
526519

527520

528521
def test_track_media_metadata_tags(session):

tidalapi/media.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ def parse_track(self, json_obj: JsonObj, album: Optional[Album] = None) -> Track
367367

368368
self.date_added = self.user_date_added
369369
self.description = json_obj.get("description")
370-
self.version = json_obj.get("version")
370+
self.version = json_obj.get("version") if json_obj.get("version") else None
371371
self.copyright = json_obj.get("copyright")
372372

373373
self.bpm = json_obj.get("bpm")

0 commit comments

Comments
 (0)