-
Notifications
You must be signed in to change notification settings - Fork 4
Description
There are (at least) two primary ways in which forcings tooling can improve in ngen-datastream:
-
Expanding forcings sources. In the current implementation of
forcingprocessor,nwmurlis called to generate URLs of national water model forcings files. So far it has been the goal to support anyurlbaseinputoption available innwmurl. Reference this document to see progress on this. Ideally,forcingprocessoris capable of processing over additional grids like Analysis of Record for Calibration (AORC). Which leads to the next improvement: weight generation. -
Implementing weight generation:
forcingprocessorextracts polygon averaged forcings data using weights provided byhfsubset.forcingprocessoris not currently capable of generating weights solely based on the polygons and forcings grid. Motivation for this choice isngen-datastreamwill store the hfsubset/hydrofabric version in the metadata so the weights are effectively versioned, whereas it is not clear how to "version" user supplied weights without saving the weights themselves to the metadata. In addition, it seemed best for the community to abstract this step from users to avoid both miscalculation and needing to update our code with each hydrofabric release. This tooling primarily exists inhfsubset, though this tool is still under development and sometimes does not produce weights for some catchments.
If forcingprocessor is to support additional grids like AORC, then we will need:
- Expanding
urlbaseinputoptions innwmurlto generate URLs for AORC (and other sources?) @jameshalgren @sepehrkrz - Allowing the user to supply weights manually at the CLI or a datastream supported weight generation algorithm. Should this repository support weight generation tools? I would prefer not to for reasons mentioned previously, but it might be a useful capability given current hinderances in the community. (@hellkite500 could your tools support this?)